lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 Jun 2020 14:41:57 +0200 From: Jan Kara <jack@...e.cz> To: "zhangyi (F)" <yi.zhang@...wei.com> Cc: linux-ext4@...r.kernel.org, tytso@....edu, jack@...e.cz, adilger.kernel@...ger.ca, zhangxiaoxu5@...wei.com, linux-fsdevel@...r.kernel.org Subject: Re: [PATCH v2 3/5] ext4: detect metadata async write error when getting journal's write access On Wed 17-06-20 19:59:45, zhangyi (F) wrote: > Although we have already introduce s_bdev_wb_err_work to detect and > handle async write metadata buffer error as soon as possible, there is > still a potential race that could lead to filesystem inconsistency, > which is the buffer may reading and re-writing out to journal before > s_bdev_wb_err_work run. So this patch detect bdev mapping->wb_err when > getting journal's write access and also mark the filesystem error if > something bad happened. > > Signed-off-by: zhangyi (F) <yi.zhang@...wei.com> So instead of all this, cannot we just do: if (work_pending(sbi->s_bdev_wb_err_work)) flush_work(sbi->s_bdev_wb_err_work); ? And so we are sure the filesystem is aborted if the abort was pending? Honza -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists