linux-ext4 - Re: [PATCH] fs: i_version mntopt gets visible through /proc/mounts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200617133357.e56dnjeapatck25w@gabell>
Date:   Wed, 17 Jun 2020 09:33:57 -0400
From:   Masayoshi Mizuma <msys.mizuma@...il.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Theodore Ts'o <tytso@....edu>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Masayoshi Mizuma <m.mizuma@...fujitsu.com>,
        linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] fs: i_version mntopt gets visible through /proc/mounts

On Wed, Jun 17, 2020 at 01:03:14AM -0700, Christoph Hellwig wrote:
> On Tue, Jun 16, 2020 at 04:21:23PM -0400, Masayoshi Mizuma wrote:
> > From: Masayoshi Mizuma <m.mizuma@...fujitsu.com>
> > 
> > /proc/mounts doesn't show 'i_version' even if iversion
> > mount option is set to XFS.
> > 
> > iversion mount option is a VFS option, not ext4 specific option.
> > Move the handler to show_sb_opts() so that /proc/mounts can show
> > 'i_version' on not only ext4 but also the other filesystem.
> 
> SB_I_VERSION is a kernel internal flag.  XFS doesn't have an i_version
> mount option.

Thank you for pointing it out, I misunderstood that for XFS.

iversion mount option is a VFS option, so I think it's good to
show 'i_version' on /proc/mounts if the filesystem has i_version feature,
like as:

$ cat /proc/mounts
...
/dev/vdb1 /mnt xfs rw,i_version,relatime,attr2,inode64,logbufs=8,logbsize=32k,noquota 0 0
...

- Masa