lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 29 Jun 2020 11:44:24 -0700
From:   Eric Biggers <>
To:     Satya Tangirala <>, Theodore Ts'o <>,
        Andreas Dilger <>
Subject: Re: [PATCH v2 4/4] ext4: add inline encryption support

On Mon, Jun 29, 2020 at 12:04:05PM +0000, Satya Tangirala via Linux-f2fs-devel wrote:
> From: Eric Biggers <>
> Wire up ext4 to support inline encryption via the helper functions which
> fs/crypto/ now provides.  This includes:
> - Adding a mount option 'inlinecrypt' which enables inline encryption
>   on encrypted files where it can be used.
> - Setting the bio_crypt_ctx on bios that will be submitted to an
>   inline-encrypted file.
>   Note: submit_bh_wbc() in fs/buffer.c also needed to be patched for
>   this part, since ext4 sometimes uses ll_rw_block() on file data.
> - Not adding logically discontiguous data to bios that will be submitted
>   to an inline-encrypted file.
> - Not doing filesystem-layer crypto on inline-encrypted files.
> Signed-off-by: Eric Biggers <>
> Co-developed-by: Satya Tangirala <>
> Signed-off-by: Satya Tangirala <>

This patch looks good to me.  (I can't technically provide Reviewed-by because
I'm listed as the author.)

Ted and Andreas, can you take a look?

- Eric

Powered by blists - more mailing lists