lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 3 Jul 2020 12:20:19 +0200 From: Jan Kara <jack@...e.cz> To: Chengguang Xu <cgxu519@...ernel.net> Cc: jack@...e.cz, linux-ext4@...r.kernel.org Subject: Re: [PATCH] ext2: delete incorrect comment for ext2_blks_to_allocate() On Thu 02-07-20 17:56:36, Chengguang Xu wrote: > ext2_blks_to_allocate() only counts direct blocks need to be allocated, > return value does not include indirect blocks. > > Signed-off-by: Chengguang Xu <cgxu519@...ernel.net> > --- > fs/ext2/inode.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c > index c8b371c82b4f..4df849e694dd 100644 > --- a/fs/ext2/inode.c > +++ b/fs/ext2/inode.c > @@ -355,9 +355,6 @@ static inline ext2_fsblk_t ext2_find_goal(struct inode *inode, long block, > * @k: number of blocks need for indirect blocks > * @blks: number of data blocks to be mapped. > * @blocks_to_boundary: the offset in the indirect block > - * > - * return the total number of blocks to be allocate, including the > - * direct and indirect blocks. You're right the comment is wrong but instead of deleting it, I'd rather fix it like: "Return the number of direct blocks to allocate." Honza -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists