lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 8 Jul 2020 15:52:08 +0530 From: Ritesh Harjani <riteshh@...ux.ibm.com> To: Yi Zhuang <zhuangyi1@...wei.com>, tytso@....edu, adilger.kernel@...ger.ca Cc: linux-ext4@...r.kernel.org Subject: Re: [PATCH v2] ext4: lost matching-pair of trace in ext4_unlink On 6/29/20 5:56 PM, Yi Zhuang wrote: > If dquot_initialize() return non-zero and trace of ext4_unlink_enter/exit > enabled then the matching-pair of trace_exit will lost in log. > > v2: > Change the new label to be "out_trace:", which makes it more clear that > it is undoing the "trace" part of the code. At the same time, fix other > similar problems in this function: > > bh = ext4_find_entry(dir, &dentry->d_name, &de, NULL); > if (IS_ERR(bh)) > return PTR_ERR(bh); > if (!bh) > goto end_unlink; > > According to Andreas' suggestion, split up the "end_unlink:" label becomes > two separate labels, and then remove the "if (handle)" check, and then > use out_bh: before the handle is started. > > Signed-off-by: Yi Zhuang <zhuangyi1@...wei.com> Nice cleanup. Feel free to add: Reviewed-by: Ritesh Harjani <riteshh@...ux.ibm.com>
Powered by blists - more mailing lists