linux-ext4 - Re: [PATCH v4 4/4] ext4: add inline encryption support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200708173452.GA32199@sol.localdomain>
Date:   Wed, 8 Jul 2020 10:34:52 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     tytso@....edu
Cc:     Satya Tangirala <satyat@...gle.com>, linux-fsdevel@...r.kernel.org,
        linux-fscrypt@...r.kernel.org, linux-ext4@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [PATCH v4 4/4] ext4: add inline encryption support

On Wed, Jul 08, 2020 at 01:18:12PM -0400, tytso@....edu wrote:
> On Thu, Jul 02, 2020 at 01:56:07AM +0000, Satya Tangirala wrote:
> > From: Eric Biggers <ebiggers@...gle.com>
> > 
> > Wire up ext4 to support inline encryption via the helper functions which
> > fs/crypto/ now provides.  This includes:
> > 
> > - Adding a mount option 'inlinecrypt' which enables inline encryption
> >   on encrypted files where it can be used.
> > 
> > - Setting the bio_crypt_ctx on bios that will be submitted to an
> >   inline-encrypted file.
> > 
> >   Note: submit_bh_wbc() in fs/buffer.c also needed to be patched for
> >   this part, since ext4 sometimes uses ll_rw_block() on file data.
> > 
> > - Not adding logically discontiguous data to bios that will be submitted
> >   to an inline-encrypted file.
> > 
> > - Not doing filesystem-layer crypto on inline-encrypted files.
> > 
> > Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> > Co-developed-by: Satya Tangirala <satyat@...gle.com>
> > Signed-off-by: Satya Tangirala <satyat@...gle.com>
> 
> Reviewed-by: Theodore Ts'o <tytso@....edu>
> 

Thanks Ted.  I've applied this patch to fscrypt.git#master for 5.9.

- Eric