[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200710160337.GA21808@lst.de>
Date: Fri, 10 Jul 2020 18:03:37 +0200
From: Christoph Hellwig <hch@....de>
To: Dave Chinner <david@...morbit.com>
Cc: "Darrick J. Wong" <darrick.wong@...cle.com>,
Matthew Wilcox <willy@...radead.org>,
Christoph Hellwig <hch@....de>,
Goldwyn Rodrigues <rgoldwyn@...e.de>,
linux-fsdevel@...r.kernel.org, linux-btrfs@...r.kernel.org,
fdmanana@...il.com, dsterba@...e.cz, cluster-devel@...hat.com,
linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org
Subject: Re: always fall back to buffered I/O after invalidation failures,
was: Re: [PATCH 2/6] iomap: IOMAP_DIO_RWF_NO_STALE_PAGECACHE return
if page invalidation fails
This looks sane - slightly updated version below to not bother with
the ret and a few tidyups.
That being said and to get back to the discussion in this thread:
I think it would be saner to give up on direct I/O in case of the
invalidation failure. I've cooked up a patch on top of this one
(for which I had a few trivial cleanups). It is still under testing,
but I'll send the two out in a new thread.
Powered by blists - more mailing lists