lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 14 Jul 2020 13:00:55 +0200
From:   Christoph Hellwig <>
To:     "Darrick J. Wong" <>
Cc:     Christoph Hellwig <>, Dave Chinner <>,
        Goldwyn Rodrigues <>,
        Damien Le Moal <>,
        Naohiro Aota <>,
        Johannes Thumshirn <>,
        Matthew Wilcox <>,,,,,
Subject: Re: [PATCH 2/2] iomap: fall back to buffered writes for
 invalidation failures

On Mon, Jul 13, 2020 at 08:39:20AM -0700, Darrick J. Wong wrote:
> -ENOTBLK is already being used as a "magic" return code that means
> "retry this direct write as a buffered write".  Shouldn't we use that
> instead?
> -EREMCHG was a private hack we put in XFS for the one case where a
> direct write had to be done through the page cache (non block-aligned
> COW), but maybe it's time we put that to rest since the rest of the
> world apparently thinks the magic fallback code is -ENOTBLK.

Sure, I can switch the error code.

Powered by blists - more mailing lists