lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Jul 2020 13:00:55 +0200 From: Christoph Hellwig <hch@....de> To: "Darrick J. Wong" <darrick.wong@...cle.com> Cc: Christoph Hellwig <hch@....de>, Dave Chinner <david@...morbit.com>, Goldwyn Rodrigues <rgoldwyn@...e.de>, Damien Le Moal <damien.lemoal@....com>, Naohiro Aota <naohiro.aota@....com>, Johannes Thumshirn <jth@...nel.org>, Matthew Wilcox <willy@...radead.org>, linux-btrfs@...r.kernel.org, linux-fsdevel@...r.kernel.org, cluster-devel@...hat.com, linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org Subject: Re: [PATCH 2/2] iomap: fall back to buffered writes for invalidation failures On Mon, Jul 13, 2020 at 08:39:20AM -0700, Darrick J. Wong wrote: > -ENOTBLK is already being used as a "magic" return code that means > "retry this direct write as a buffered write". Shouldn't we use that > instead? > > -EREMCHG was a private hack we put in XFS for the one case where a > direct write had to be done through the page cache (non block-aligned > COW), but maybe it's time we put that to rest since the rest of the > world apparently thinks the magic fallback code is -ENOTBLK. Sure, I can switch the error code.
Powered by blists - more mailing lists