lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Jul 2020 13:35:05 -0700 From: "Darrick J. Wong" <darrick.wong@...cle.com> To: Christoph Hellwig <hch@....de> Cc: Dave Chinner <david@...morbit.com>, Goldwyn Rodrigues <rgoldwyn@...e.de>, Damien Le Moal <damien.lemoal@....com>, Naohiro Aota <naohiro.aota@....com>, Johannes Thumshirn <jth@...nel.org>, Matthew Wilcox <willy@...radead.org>, linux-btrfs@...r.kernel.org, linux-fsdevel@...r.kernel.org, cluster-devel@...hat.com, linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org Subject: Re: [PATCH 1/3] xfs: use ENOTBLK for direct I/O to buffered I/O fallback On Tue, Jul 21, 2020 at 08:31:55PM +0200, Christoph Hellwig wrote: > This is what the classic fs/direct-io.c implementation and thuse other > file systems use. > > Signed-off-by: Christoph Hellwig <hch@....de> Looks ok to me, Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com> --D > --- > fs/xfs/xfs_file.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index 00db81eac80d6c..a6ef90457abf97 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -505,7 +505,7 @@ xfs_file_dio_aio_write( > */ > if (xfs_is_cow_inode(ip)) { > trace_xfs_reflink_bounce_dio_write(ip, iocb->ki_pos, count); > - return -EREMCHG; > + return -ENOTBLK; > } > iolock = XFS_IOLOCK_EXCL; > } else { > @@ -714,7 +714,7 @@ xfs_file_write_iter( > * allow an operation to fall back to buffered mode. > */ > ret = xfs_file_dio_aio_write(iocb, from); > - if (ret != -EREMCHG) > + if (ret != -ENOTBLK) > return ret; > } > > -- > 2.27.0 >
Powered by blists - more mailing lists