linux-ext4 - Re: [Cluster-devel] [PATCH 3/3] iomap: fall back to buffered writes for invalidation failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <595939815.7378944.1595420398243.JavaMail.zimbra@redhat.com>
Date:   Wed, 22 Jul 2020 08:19:58 -0400 (EDT)
From:   Bob Peterson <rpeterso@...hat.com>
To:     "Darrick J. Wong" <darrick.wong@...cle.com>
Cc:     Christoph Hellwig <hch@....de>,
        Naohiro Aota <naohiro.aota@....com>, linux-xfs@...r.kernel.org,
        Damien Le Moal <damien.lemoal@....com>,
        linux-ext4@...r.kernel.org, Goldwyn Rodrigues <rgoldwyn@...e.de>,
        Dave Chinner <david@...morbit.com>,
        Matthew Wilcox <willy@...radead.org>, cluster-devel@...hat.com,
        Goldwyn Rodrigues <rgoldwyn@...e.com>,
        linux-fsdevel@...r.kernel.org, Johannes Thumshirn <jth@...nel.org>,
        linux-btrfs@...r.kernel.org
Subject: Re: [Cluster-devel] [PATCH 3/3] iomap: fall back to buffered writes
 for invalidation failures

----- Original Message -----
> On Tue, Jul 21, 2020 at 08:31:57PM +0200, Christoph Hellwig wrote:
> > Failing to invalid the page cache means data in incoherent, which is
> > a very bad state for the system.  Always fall back to buffered I/O
> > through the page cache if we can't invalidate mappings.
> > 
> > Signed-off-by: Christoph Hellwig <hch@....de>
> > Acked-by: Dave Chinner <dchinner@...hat.com>
> > Reviewed-by: Goldwyn Rodrigues <rgoldwyn@...e.com>
> 
> For the iomap and xfs parts,
> Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>
> 
> But I'd still like acks from Ted, Andreas, and Damien for ext4, gfs2,
> and zonefs, respectively.
> 
> (Particularly if anyone was harboring ideas about trying to get this in
> before 5.10, though I've not yet heard anyone say that explicitly...)
> 
> --D
> 
> > ---
> >  fs/ext4/file.c       |  2 ++
> >  fs/gfs2/file.c       |  3 ++-
> >  fs/iomap/direct-io.c | 16 +++++++++++-----
> >  fs/iomap/trace.h     |  1 +
> >  fs/xfs/xfs_file.c    |  4 ++--
> >  fs/zonefs/super.c    |  7 +++++--
> >  6 files changed, 23 insertions(+), 10 deletions(-)

Hi,

I think Andreas is on holiday this week, but the gfs2 portion looks good to me:

For the gfs2 portion:
Acked-by: Bob Peterson <rpeterso@...hat.com>

Regards,

Bob Peterson