linux-ext4 - Re: [PATCH] ext4:remove some redundant function declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200724025815.789D952050@d06av21.portsmouth.uk.ibm.com>
Date:   Fri, 24 Jul 2020 08:28:14 +0530
From:   Ritesh Harjani <riteshh@...ux.ibm.com>
To:     Shijie Luo <luoshijie1@...wei.com>, linux-ext4@...r.kernel.org
Cc:     tytso@....edu, jack@...e.cz
Subject: Re: [PATCH] ext4:remove some redundant function declarations



On 7/24/20 7:17 AM, Shijie Luo wrote:
> ext4 update feature functions do not exist now, remove these useless
> function declarations.
> 
> Signed-off-by: Shijie Luo <luoshijie1@...wei.com>

LGTM, feel free to add:
Reviewed-by: Ritesh Harjani <riteshh@...ux.ibm.com>

> ---
>   fs/ext4/ext4.h | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 42f5060f3cdf..196b52c75422 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -2924,12 +2924,6 @@ do {									\
> 
>   #endif
> 
> -extern int ext4_update_compat_feature(handle_t *handle, struct super_block *sb,
> -					__u32 compat);
> -extern int ext4_update_rocompat_feature(handle_t *handle,
> -					struct super_block *sb,	__u32 rocompat);
> -extern int ext4_update_incompat_feature(handle_t *handle,
> -					struct super_block *sb,	__u32 incompat);
>   extern ext4_fsblk_t ext4_block_bitmap(struct super_block *sb,
>   				      struct ext4_group_desc *bg);
>   extern ext4_fsblk_t ext4_inode_bitmap(struct super_block *sb,
>