linux-ext4 - Re: [PATCH] jbd2: fix incorrect code style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Jul 2020 10:35:44 +0200
From:   Jan Kara <jack@...e.cz>
To:     Xianting Tian <xianting_tian@....com>
Cc:     tytso@....edu, jack@...e.com, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] jbd2: fix incorrect code style

On Sat 18-07-20 08:57:37, Xianting Tian wrote:
> Remove unnecessary blank.
> 
> Signed-off-by: Xianting Tian <xianting_tian@....com>

Looks fine. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/jbd2/journal.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index e494443..5eccf8c 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -1285,7 +1285,7 @@ journal_t *jbd2_journal_init_inode(struct inode *inode)
>   * superblock as being NULL to prevent the journal destroy from writing
>   * back a bogus superblock.
>   */
> -static void journal_fail_superblock (journal_t *journal)
> +static void journal_fail_superblock(journal_t *journal)
>  {
>  	struct buffer_head *bh = journal->j_sb_buffer;
>  	brelse(bh);
> @@ -1815,7 +1815,7 @@ int jbd2_journal_destroy(journal_t *journal)
>  
>  
>  /**
> - *int jbd2_journal_check_used_features () - Check if features specified are used.
> + *int jbd2_journal_check_used_features() - Check if features specified are used.
>   * @journal: Journal to check.
>   * @compat: bitmask of compatible features
>   * @ro: bitmask of features that force read-only mount
> @@ -1825,7 +1825,7 @@ int jbd2_journal_destroy(journal_t *journal)
>   * features.  Return true (non-zero) if it does.
>   **/
>  
> -int jbd2_journal_check_used_features (journal_t *journal, unsigned long compat,
> +int jbd2_journal_check_used_features(journal_t *journal, unsigned long compat,
>  				 unsigned long ro, unsigned long incompat)
>  {
>  	journal_superblock_t *sb;
> @@ -1860,7 +1860,7 @@ int jbd2_journal_check_used_features (journal_t *journal, unsigned long compat,
>   * all of a given set of features on this journal.  Return true
>   * (non-zero) if it can. */
>  
> -int jbd2_journal_check_available_features (journal_t *journal, unsigned long compat,
> +int jbd2_journal_check_available_features(journal_t *journal, unsigned long compat,
>  				      unsigned long ro, unsigned long incompat)
>  {
>  	if (!compat && !ro && !incompat)
> @@ -1882,7 +1882,7 @@ int jbd2_journal_check_available_features (journal_t *journal, unsigned long com
>  }
>  
>  /**
> - * int jbd2_journal_set_features () - Mark a given journal feature in the superblock
> + * int jbd2_journal_set_features() - Mark a given journal feature in the superblock
>   * @journal: Journal to act on.
>   * @compat: bitmask of compatible features
>   * @ro: bitmask of features that force read-only mount
> @@ -1893,7 +1893,7 @@ int jbd2_journal_check_available_features (journal_t *journal, unsigned long com
>   *
>   */
>  
> -int jbd2_journal_set_features (journal_t *journal, unsigned long compat,
> +int jbd2_journal_set_features(journal_t *journal, unsigned long compat,
>  			  unsigned long ro, unsigned long incompat)
>  {
>  #define INCOMPAT_FEATURE_ON(f) \
> -- 
> 1.8.3.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR