linux-ext4 - Re: [PATCH v3] ext4: don't BUG on inconsistent journal feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200806051108.GH7657@mit.edu>
Date:   Thu, 6 Aug 2020 01:11:08 -0400
From:   tytso@....edu
To:     Jan Kara <jack@...e.cz>
Cc:     <linux-ext4@...r.kernel.org>, Lukas Czerner <lczerner@...hat.com>
Subject: Re: [PATCH v3] ext4: don't BUG on inconsistent journal feature

On Fri, Jul 10, 2020 at 04:07:59PM +0200, Jan Kara wrote:
> A customer has reported a BUG_ON in ext4_clear_journal_err() hitting
> during an LTP testing. Either this has been caused by a test setup
> issue where the filesystem was being overwritten while LTP was mounting
> it or the journal replay has overwritten the superblock with invalid
> data. In either case it is preferable we don't take the machine down
> with a BUG_ON. So handle the situation of unexpectedly missing
> has_journal feature more gracefully. We issue warning and fail the mount
> in the cases where the race window is narrow and the failed check is
> most likely a programming error. In cases where fs corruption is more
> likely, we do full ext4_error() handling before failing mount / remount.
> 
> Reviewed-by: Lukas Czerner <lczerner@...hat.com>
> Signed-off-by: Jan Kara <jack@...e.cz>

Applied, thanks.

						- Ted