linux-ext4 - Re: [PATCH] jbd2: add the missing unlock_buffer() in the error path of jbd2_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200806041614.GB7657@mit.edu>
Date:   Thu, 6 Aug 2020 00:16:14 -0400
From:   tytso@....edu
To:     "zhangyi (F)" <yi.zhang@...wei.com>
Cc:     <linux-ext4@...r.kernel.org>, <jack@...e.cz>,
        <jiufei.xue@...ux.alibaba.com>
Subject: Re: [PATCH] jbd2: add the missing unlock_buffer() in the error path
 of jbd2_write_superblock()

On Sat, Jun 20, 2020 at 02:19:48PM +0800, zhangyi (F) wrote:
> jbd2_write_superblock() is under the buffer lock of journal superblock
> before ending that superblock write, so add a missing unlock_buffer() in
> in the error path before submitting buffer.
> 
> Fixes: 742b06b5628f ("jbd2: check superblock mapped prior to committing")
> Signed-off-by: zhangyi (F) <yi.zhang@...wei.com>
> Cc: stable@...nel.org

Thanks, applied.

						- Ted