linux-ext4 - Re: [PATCH v3 4/5] jbd2: abort journal if free a async write error metadata buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200807175924.GX7657@mit.edu>
Date:   Fri, 7 Aug 2020 13:59:24 -0400
From:   tytso@....edu
To:     "zhangyi (F)" <yi.zhang@...wei.com>
Cc:     <linux-ext4@...r.kernel.org>, <jack@...e.cz>,
        <adilger.kernel@...ger.ca>, <zhangxiaoxu5@...wei.com>,
        <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH v3 4/5] jbd2: abort journal if free a async write error
 metadata buffer

On Sat, Jun 20, 2020 at 10:54:26AM +0800, zhangyi (F) wrote:
> If we free a metadata buffer which has been failed to async write out
> in the background, the jbd2 checkpoint procedure will not detect this
> failure in jbd2_log_do_checkpoint(), so it may lead to filesystem
> inconsistency after cleanup journal tail. This patch abort the journal
> if free a buffer has write_io_error flag to prevent potential further
> inconsistency.
> 
> Signed-off-by: zhangyi (F) <yi.zhang@...wei.com>

Thanks, applied.

					- Ted