lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1596894336-49052-1-git-send-email-xianting_tian@126.com> Date: Sat, 8 Aug 2020 09:45:36 -0400 From: Xianting Tian <xianting_tian@....com> To: tytso@....edu, adilger.kernel@...ger.ca Cc: linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, clang-built-linux@...glegroups.com Subject: [PATCH] ext4: use kmemdup_nul() instead of kstrndup() kmemdup_nul() is more efficient than kmemdup_nul() if the size is known exactly. The description of kstrndup() already suggested: Note: Use kmemdup_nul() instead if the size is known exactly. Signed-off-by: Xianting Tian <xianting_tian@....com> --- fs/ext4/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 330957e..be37556 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -4016,7 +4016,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) } if (sbi->s_es->s_mount_opts[0]) { - char *s_mount_opts = kstrndup(sbi->s_es->s_mount_opts, + char *s_mount_opts = kmemdup_nul(sbi->s_es->s_mount_opts, sizeof(sbi->s_es->s_mount_opts), GFP_KERNEL); if (!s_mount_opts) -- 1.8.3.1
Powered by blists - more mailing lists