linux-ext4 - Re: [PATCH] ext4: delete invalid comments near ext4_mb_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200813153517.097F2A405B@d06av23.portsmouth.uk.ibm.com>
Date:   Thu, 13 Aug 2020 21:05:16 +0530
From:   Ritesh Harjani <riteshh@...ux.ibm.com>
To:     brookxu <brookxu.cn@...il.com>, adilger.kernel@...ger.ca,
        tytso@....edu, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: delete invalid comments near ext4_mb_check_limits()



On 8/7/20 7:31 PM, brookxu wrote:
> These comments do not seem to be related to ext4_mb_check_limits(),
> it may be invalid.
> 
> Signed-off-by: Chunguang Xu <brookxu@...cent.com>

Either ways these comments are of no help and the
function has enough comments within.
So we should be good without it.

Reviewed-by: Ritesh Harjani <riteshh@...ux.ibm.com>

> ---
>   fs/ext4/mballoc.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 577ce98..aaefeb4 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -1743,10 +1743,6 @@ static void ext4_mb_use_best_found(struct ext4_allocation_context *ac,
> 
>   }
> 
> -/*
> - * regular allocator, for general purposes allocation
> - */
> -
>   static void ext4_mb_check_limits(struct ext4_allocation_context *ac,
>   					struct ext4_buddy *e4b,
>   					int finish_group)
>