linux-ext4 - Re: [PATCH] ext4: fix typos in ext4_mb_regular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D636E979-399D-46F2-8F67-EFB135AEF2B8@dilger.ca>
Date:   Thu, 13 Aug 2020 02:20:18 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     brookxu <brookxu.cn@...il.com>
Cc:     Theodore Ts'o <tytso@....edu>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: fix typos in ext4_mb_regular_allocator() comment


> On Aug 7, 2020, at 8:01 AM, brookxu <brookxu.cn@...il.com> wrote:
> 
> Fix typos in ext4_mb_regular_allocator() comment
> 
> Signed-off-by: Chunguang Xu <brookxu@...cent.com>

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> fs/ext4/mballoc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 4f21f34..0edec26 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -2237,8 +2237,8 @@ static int ext4_mb_good_group_nolock(struct ext4_allocation_context *ac,
> 		goto out;
> 
> 	/*
> -	 * ac->ac2_order is set only if the fe_len is a power of 2
> -	 * if ac2_order is set we also set criteria to 0 so that we
> +	 * ac->ac_2order is set only if the fe_len is a power of 2
> +	 * if ac->ac_2order is set we also set criteria to 0 so that we
> 	 * try exact allocation using buddy.
> 	 */
> 	i = fls(ac->ac_g_ex.fe_len);
> --
> 1.8.3.1


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)