lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20200818181848.GD34125@mit.edu> Date: Tue, 18 Aug 2020 14:18:48 -0400 From: "Theodore Y. Ts'o" <tytso@....edu> To: brookxu <brookxu.cn@...il.com> Cc: adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org Subject: Re: [PATCH] ext4: optimize the implementation of ext4_mb_good_group() On Fri, Aug 07, 2020 at 10:01:39PM +0800, brookxu wrote: > It might be better to adjust the code in two places: > 1. Determine whether grp is currupt or not should be placed first. > 2. (cr<=2 && free <ac->ac_g_ex.fe_len)should may belong to the crx > strategy, and it may be more appropriate to put it in the > subsequent switch statement block. For cr1, cr2, the conditions > in switch potentially realize the above judgment. For cr0, we > should add (free <ac->ac_g_ex.fe_len) judgment, and then delete > (free / fragments) >= ac->ac_g_ex.fe_len), because cr0 returns > true by default. > > Signed-off-by: Chunguang Xu <brookxu@...cent.com> Thanks, applied. - Ted
Powered by blists - more mailing lists