linux-ext4 - Re: [PATCH] ext4: Fix unnecessary hold lock when judge jinode in ext4_inode_attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5F40E587.1080002@huawei.com>
Date:   Sat, 22 Aug 2020 17:29:43 +0800
From:   yebin <yebin10@...wei.com>
To:     <adilger.kernel@...ger.ca>, <tytso@....edu>,
        <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: Fix unnecessary hold lock when judge jinode in
 ext4_inode_attach_jinode

Sorry, please  ignore it.

On 2020/8/22 17:25, Ye Bin wrote:
> Signed-off-by: Ye Bin <yebin10@...wei.com>
> ---
>   fs/ext4/inode.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 3a196d81f594..3504b4cec5b8 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -4100,12 +4100,11 @@ int ext4_inode_attach_jinode(struct inode *inode)
>   		return 0;
>   
>   	jinode = jbd2_alloc_inode(GFP_KERNEL);
> +	if (!jinode)
> +		return -ENOMEM;
> +
>   	spin_lock(&inode->i_lock);
>   	if (!ei->jinode) {
> -		if (!jinode) {
> -			spin_unlock(&inode->i_lock);
> -			return -ENOMEM;
> -		}
>   		ei->jinode = jinode;
>   		jbd2_journal_init_jbd_inode(ei->jinode, inode);
>   		jinode = NULL;