lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 25 Aug 2020 11:40:34 +0100
From:   Yuxuan Shui <>
To:     Christoph Hellwig <>
Cc:     "Darrick J. Wong" <>,,,,,
Subject: Re: [PATCH] iomap: iomap_bmap should accept unwritten maps


On Tue, Aug 25, 2020 at 11:20 AM Christoph Hellwig <> wrote:
> On Tue, Aug 25, 2020 at 10:26:14AM +0100, Yuxuan Shui wrote:
> > Hi,
> >
> > Do we actually want to fix this bug or not? There are a number of
> > people actually seeing this bug.
> bmap should not succeed for unwritten extents.

Why not? Unwritten extents are still allocated extents.

> > If you think this is not the right fix, what do you think we should
> > do? If the correct fix is to make ext4 use iomap_swapfile_activate,
> > maybe we should CC the ext4 people too?
> Yes, ext4 should use iomap_swapfile_activate.

OK, let me CC the ext4 people.


> commit ac58e4fb03f9d111d733a4ad379d06eef3a24705 moved ext4_bmap from
> generic_block_bmap to iomap_bmap, this introduced a regression which
> prevents some user from using previously working swapfiles. The kernel
> will complain about holes while there are none.

> What is happening here is that the swapfile has unwritten mappings,
> which is rejected by iomap_bmap, but was accepted by ext4_get_block.


Yuxuan Shui

Powered by blists - more mailing lists