linux-ext4 - Re: [PATCH 3/4] e2fsck: use the right conversion specifier in e2fsck_allocate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201001204943.GP23474@mit.edu>
Date:   Thu, 1 Oct 2020 16:49:43 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Lukas Czerner <lczerner@...hat.com>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH 3/4] e2fsck: use the right conversion specifier in
 e2fsck_allocate_memory()

Thanks, I had fixed this in one place, but the fix under the #ifdef
DEBUG_ALLOCATE_MEMORY needed, so that part has been applied.

		      	      	 - Ted

On Fri, Jun 05, 2020 at 10:14:41AM +0200, Lukas Czerner wrote:
> Signed-off-by: Lukas Czerner <lczerner@...hat.com>
> ---
>  e2fsck/util.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/e2fsck/util.c b/e2fsck/util.c
> index 88e0ea8a..79916928 100644
> --- a/e2fsck/util.c
> +++ b/e2fsck/util.c
> @@ -123,10 +123,10 @@ void *e2fsck_allocate_memory(e2fsck_t ctx, unsigned long size,
>  	char buf[256];
>  
>  #ifdef DEBUG_ALLOCATE_MEMORY
> -	printf("Allocating %u bytes for %s...\n", size, description);
> +	printf("Allocating %lu bytes for %s...\n", size, description);
>  #endif
>  	if (ext2fs_get_memzero(size, &ret)) {
> -		sprintf(buf, "Can't allocate %u bytes for %s\n",
> +		sprintf(buf, "Can't allocate %lu bytes for %s\n",
>  			size, description);
>  		fatal_error(ctx, buf);
>  	}
> -- 
> 2.21.3
>