linux-ext4 - Re: [PATCH] tune2fs: reset MMP state on error exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201001142637.GG23474@mit.edu>
Date:   Thu, 1 Oct 2020 10:26:37 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     linux-ext4@...r.kernel.org, Andreas Dilger <adilger@...mcloud.com>
Subject: Re: [PATCH] tune2fs: reset MMP state on error exit

On Wed, Jun 17, 2020 at 05:40:49AM -0600, Andreas Dilger wrote:
> From: Andreas Dilger <adilger@...mcloud.com>
> 
> If tune2fs cannot perform the requested change, ensure that the MMP
> block is reset to the unused state before exiting.  Otherwise, the
> filesystem will be left with mmp_seq = EXT4_MMP_SEQ_FSCK set, which
> prevents it from being mounted afterward:
> 
>     EXT4-fs warning (device dm-9): ext4_multi_mount_protect:311:
>         fsck is running on the filesystem
> 
> Add a test to try some failed tune2fs operations and verify that the
> MMP block is left in a clean state afterward.
> 
> Lustre-bug-id: https://jira.whamcloud.com/browse/LU-13672
> Signed-off-by: Andreas Dilger <adilger@...mcloud.com>

Applied, thanks.

					- Ted