lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 1 Oct 2020 10:36:47 -0400 From: "Theodore Y. Ts'o" <tytso@....edu> To: Florian Schmaus <flo@...kplace.eu> Cc: linux-ext4@...r.kernel.org Subject: Re: [PATCH v2] e4crypt: if salt is explicitly provided to add_key, then use it On Tue, Jul 07, 2020 at 10:27:30AM +0200, Florian Schmaus wrote: > Providing -S and a path to 'add_key' previously exhibit an unintuitive > behavior: instead of using the salt explicitly provided by the user, > e4crypt would use the salt obtained via EXT4_IOC_GET_ENCRYPTION_PWSALT > on the path. This was because set_policy() was still called with NULL > as salt. > > With this change we now remember the explicitly provided salt (if any) > and use it as argument for set_policy(). > > Eventually > > e4crypt add_key -S s:my-spicy-salt /foo > > will now actually use 'my-spicy-salt' and not something else as salt > for the policy set on /foo. > > Signed-off-by: Florian Schmaus <flo@...kplace.eu> Applied, with the spell correction Eric pointed out. - Ted
Powered by blists - more mailing lists