linux-ext4 - Re: [PATCH] tests: replace perl usage with shell built-in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <7C748802-8CC0-4881-90B3-DF362CACD902@dilger.ca>
Date:   Thu, 1 Oct 2020 20:05:45 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     "Theodore Y. Ts'o" <tytso@....EDU>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] tests: replace perl usage with shell built-in

On Oct 1, 2020, at 11:08 AM, Theodore Y. Ts'o <tytso@....EDU> wrote:
> 
> On Thu, Oct 01, 2020 at 10:58:09AM -0400, Theodore Y. Ts'o wrote:
>> On Sun, Jul 19, 2020 at 05:00:33AM -0600, Andreas Dilger wrote:
>>> A couple of tests use perl only for generating a string of
>>> N characters long.  Instead of requiring perl to run a few
>>> tests, use shell built-in commands and don't repeatedly run
>>> a separate subshell just to get a string of characters.
>>> h
>>> Signed-off-by: Andreas Dilger <adilger@...ger.ca>
>> 
>> Thanks, applied.
> 
> .... and I have to revert the patch.  It's using a non-standard shell
> construction which fails on strict POSIX compliant shells, such as
> dash.

Could you please point out which constructs it is unhappy with?  I had
an earlier version of the patch using a different mechanism, but then
updated it after feedback from Lukas.

Cheers, Andreas

Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)