linux-ext4 - Re: [PATCH] ext4: fix leaking sysfs kobject after failed mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201003045628.GH23474@mit.edu>
Date:   Sat, 3 Oct 2020 00:56:28 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     Eric Biggers <ebiggers@...nel.org>, linux-ext4@...r.kernel.org,
        syzkaller-bugs@...glegroups.com, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org,
        syzbot+9f864abad79fae7c17e1@...kaller.appspotmail.com
Subject: Re: [PATCH] ext4: fix leaking sysfs kobject after failed mount

On Thu, Sep 24, 2020 at 11:08:59AM +0200, Jan Kara wrote:
> On Tue 22-09-20 09:24:56, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@...gle.com>
> > 
> > ext4_unregister_sysfs() only deletes the kobject.  The reference to it
> > needs to be put separately, like ext4_put_super() does.
> > 
> > This addresses the syzbot report
> > "memory leak in kobject_set_name_vargs (3)"
> > (https://syzkaller.appspot.com/bug?extid=9f864abad79fae7c17e1).
> > 
> > Reported-by: syzbot+9f864abad79fae7c17e1@...kaller.appspotmail.com
> > Fixes: 72ba74508b28 ("ext4: release sysfs kobject when failing to enable quotas on mount")
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> 
> Looks good. You can add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>

Thanks, applied.

					- Ted