lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 3 Oct 2020 01:09:29 -0400 From: "Theodore Y. Ts'o" <tytso@....edu> To: Zhang Xiaoxu <zhangxiaoxu5@...wei.com> Cc: yi.zhang@...wei.com, jack@...e.cz, linux-ext4@...r.kernel.org, adilger.kernel@...ger.ca Subject: Re: [PATCH v3] ext4: Fix bdev write error check failed when mount fs with ro On Sun, Sep 27, 2020 at 10:05:56PM -0400, Zhang Xiaoxu wrote: > Consider a situation when a filesystem was uncleanly shutdown and the > orphan list is not empty and a read-only mount is attempted. The orphan > list cleanup during mount will fail with: > > ext4_check_bdev_write_error:193: comm mount: Error while async write back metadata > > This happens because sbi->s_bdev_wb_err is not initialized when mounting > the filesystem in read only mode and so ext4_check_bdev_write_error() > falsely triggers. > > Initialize sbi->s_bdev_wb_err unconditionally to avoid this problem. > > Fixes: bc71726c7257 ("ext4: abort the filesystem if failed to async write metadata buffer") > Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@...wei.com> > Reviewed-by: Jan Kara <jack@...e.cz> Applied, thanks. - Ted
Powered by blists - more mailing lists