linux-ext4 - Re: [PATCH v2] ext4: Disallow modifying DAX inode flag if inline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201003041321.GB23474@mit.edu>
Date:   Sat, 3 Oct 2020 00:13:21 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Xiao Yang <yangx.jy@...fujitsu.com>
Cc:     linux-ext4@...r.kernel.org, darrick.wong@...cle.com,
        ira.weiny@...el.com, jack@...e.cz
Subject: Re: [PATCH v2] ext4: Disallow modifying DAX inode flag if
 inline_data has been set

On Fri, Aug 28, 2020 at 04:43:30PM +0800, Xiao Yang wrote:
> inline_data is mutually exclusive to DAX so enabling both of them triggers
> the following issue:
> ------------------------------------------
> # mkfs.ext4 -F -O inline_data /dev/pmem1
> ...
> # mount /dev/pmem1 /mnt
> # echo 'test' >/mnt/file
> # lsattr -l /mnt/file
> /mnt/file                    Inline_Data
> # xfs_io -c "chattr +x" /mnt/file
> # xfs_io -c "lsattr -v" /mnt/file
> [dax] /mnt/file
> # umount /mnt
> # mount /dev/pmem1 /mnt
> # cat /mnt/file
> cat: /mnt/file: Numerical result out of range
> ------------------------------------------
> 
> Fixes: b383a73f2b83 ("fs/ext4: Introduce DAX inode flag")
> Signed-off-by: Xiao Yang <yangx.jy@...fujitsu.com>
> Reviewed-by: Jan Kara <jack@...e.cz>

Applied, thanks.

					- Ted