linux-ext4 - Re: [PATCH v4] jbd2: avoid transaction reuse after reformatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201009021651.GI235506@mit.edu>
Date:   Thu, 8 Oct 2020 22:16:51 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
        Fengnan Chang <changfengnan@...vision.com>,
        changfengnan <fengnanchang@...mail.com>
Subject: Re: [PATCH v4] jbd2: avoid transaction reuse after reformatting

On Thu, Oct 08, 2020 at 02:13:02PM -0600, Andreas Dilger wrote:
> On Oct 7, 2020, at 2:13 AM, Jan Kara <jack@...e.cz> wrote:
> > 
> > From: changfengnan <fengnanchang@...mail.com>
> > 
> > When ext4 is formatted with lazy_journal_init=1 and transactions from
> > the previous filesystem are still on disk, it is possible that they are
> > considered during a recovery after a crash. Because the checksum seed
> > has changed, the CRC check will fail, and the journal recovery fails
> > with checksum error although the journal is otherwise perfectly valid.
> > Fix the problem by checking commit block time stamps to determine
> > whether the data in the journal block is just stale or whether it is
> > indeed corrupt.
> > 
> > Reported-by: kernel test robot <lkp@...el.com>
> > Signed-off-by: Fengnan Chang <changfengnan@...vision.com>
> > Signed-off-by: Jan Kara <jack@...e.cz>
> 
> Reviewed-by: Andreas Dilger <adilger@...ger.ca>
> 
> NB: one trivial formatting cleanup if patch is refreshed
>

Applied, thanks.  I fixed the trivial format cleanup you pointed out,
plus a whitespace fix pointed out by checkpatch.

       		      	      	     - Ted