linux-ext4 - ext4: dev: Broken with CONFIG_JBD2=and CONFIG_EXT4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+icZUWkE5CVtGGo88zo9b28JB1rN7=Gpc4hXywUaqjdCcSyOw@mail.gmail.com>
Date:   Fri, 9 Oct 2020 15:49:11 +0200
From:   Sedat Dilek <sedat.dilek@...il.com>
To:     "Theodore Y. Ts'o" <tytso@....edu>
Cc:     linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: ext4: dev: Broken with CONFIG_JBD2=and CONFIG_EXT4_FS=m

Hi Ted,

with <ext4.git#dev> up to commit
ab7b179af3f98772f2433ddc4ace6b7924a4e862 ("Merge branch
'hs/fast-commit-v9' into dev") I see some warnings (were reported via
kernel-test-bot)...

fs/jbd2/recovery.c:241:15: warning: unused variable 'seq' [-Wunused-variable]
fs/ext4/fast_commit.c:1091:6: warning: variable 'start_time' is used
uninitialized whenever 'if' condition is true
[-Wsometimes-uninitialized]
fs/ext4/fast_commit.c:1091:6: warning: variable 'start_time' is used
uninitialized whenever '||' condition is true
[-Wsometimes-uninitialized]

...and more severe a build breakage with CONFIG_JBD2=and CONFIG_EXT4_FS=m

ERROR: modpost: "jbd2_fc_release_bufs" [fs/ext4/ext4.ko] undefined!
ERROR: modpost: "jbd2_fc_init" [fs/ext4/ext4.ko] undefined!
ERROR: modpost: "jbd2_fc_stop_do_commit" [fs/ext4/ext4.ko] undefined!
ERROR: modpost: "jbd2_fc_stop" [fs/ext4/ext4.ko] undefined!
ERROR: modpost: "jbd2_fc_start" [fs/ext4/ext4.ko] undefined!

Looks like missing exports.

Regards,
- Sedat -