linux-ext4 - Re: ext4: dev: Broken with CONFIG_JBD2=and CONFIG_EXT4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD+ocbzz_7KwzMo6UpSLef6i7aFWg9O+25DqtOGj=nvRNqbcsQ@mail.gmail.com>
Date:   Tue, 13 Oct 2020 10:43:24 -0700
From:   harshad shirwadkar <harshadshirwadkar@...il.com>
To:     Sedat Dilek <sedat.dilek@...il.com>
Cc:     "Theodore Y. Ts'o" <tytso@....edu>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>,
        linux-fsdevel@...r.kernel.org
Subject: Re: ext4: dev: Broken with CONFIG_JBD2=and CONFIG_EXT4_FS=m

Thanks Sedat, I'll take care of this in V10.

On Fri, Oct 9, 2020 at 8:14 PM Sedat Dilek <sedat.dilek@...il.com> wrote:
>
> On Fri, Oct 9, 2020 at 6:04 PM harshad shirwadkar
> <harshadshirwadkar@...il.com> wrote:
> >
> > Thanks Sedat for pointing that out and also sending out the fixes.
> > Ted, should I send out another version of fast commits out with
> > Sedat's fixes?
> >
>
> Hi Harshad,
>
> when you work on v10, can you look at these warnings, please?
>
> fs/jbd2/recovery.c:241:15: warning: unused variable 'seq' [-Wunused-variable]
> fs/ext4/fast_commit.c:1091:6: warning: variable 'start_time' is used
> uninitialized whenever 'if' condition is true
> [-Wsometimes-uninitialized]
> fs/ext4/fast_commit.c:1091:6: warning: variable 'start_time' is used
> uninitialized whenever '||' condition is true
> [-Wsometimes-uninitialized]
>
> Thanks,
> - Sedat -
>
> P.S.: Now, I see that ext4.git#dev has dropped the hs/fast-commit v9 merge.
>
> >
> >
> > On Fri, Oct 9, 2020 at 8:45 AM Theodore Y. Ts'o <tytso@....edu> wrote:
> > >
> > > On Fri, Oct 09, 2020 at 04:31:51PM +0200, Sedat Dilek wrote:
> > > > > This fixes it...
> > >
> > > Sedat,
> > >
> > > Thanks for the report and the proposed fixes!
> > >
> > >                                         - Ted