lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Oct 2020 13:50:12 -0700 From: Ira Weiny <ira.weiny@...el.com> To: Al Viro <viro@...iv.linux.org.uk> Cc: Matthew Wilcox <willy@...radead.org>, Dan Williams <dan.j.williams@...el.com>, Andrew Morton <akpm@...ux-foundation.org>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Andy Lutomirski <luto@...nel.org>, Peter Zijlstra <peterz@...radead.org>, Nicolas Pitre <nico@...xnic.net>, X86 ML <x86@...nel.org>, Dave Hansen <dave.hansen@...ux.intel.com>, Fenghua Yu <fenghua.yu@...el.com>, Linux Doc Mailing List <linux-doc@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-nvdimm <linux-nvdimm@...ts.01.org>, linux-fsdevel <linux-fsdevel@...r.kernel.org>, Linux MM <linux-mm@...ck.org>, linux-kselftest@...r.kernel.org, linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>, KVM list <kvm@...r.kernel.org>, Netdev <netdev@...r.kernel.org>, bpf@...r.kernel.org, Kexec Mailing List <kexec@...ts.infradead.org>, linux-bcache@...r.kernel.org, linux-mtd@...ts.infradead.org, devel@...verdev.osuosl.org, linux-efi <linux-efi@...r.kernel.org>, linux-mmc@...r.kernel.org, linux-scsi <linux-scsi@...r.kernel.org>, target-devel@...r.kernel.org, linux-nfs@...r.kernel.org, ceph-devel@...r.kernel.org, linux-ext4 <linux-ext4@...r.kernel.org>, linux-aio@...ck.org, io-uring@...r.kernel.org, linux-erofs@...ts.ozlabs.org, linux-um@...ts.infradead.org, linux-ntfs-dev@...ts.sourceforge.net, reiserfs-devel@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net, linux-nilfs@...r.kernel.org, cluster-devel@...hat.com, ecryptfs@...r.kernel.org, linux-cifs@...r.kernel.org, linux-btrfs <linux-btrfs@...r.kernel.org>, linux-afs@...ts.infradead.org, linux-rdma <linux-rdma@...r.kernel.org>, amd-gfx list <amd-gfx@...ts.freedesktop.org>, Maling list - DRI developers <dri-devel@...ts.freedesktop.org>, intel-gfx@...ts.freedesktop.org, drbd-dev@...ts.linbit.com, linux-block@...r.kernel.org, xen-devel <xen-devel@...ts.xenproject.org>, linux-cachefs@...hat.com, samba-technical@...ts.samba.org, intel-wired-lan@...ts.osuosl.org Subject: Re: [PATCH RFC PKS/PMEM 33/58] fs/cramfs: Utilize new kmap_thread() On Tue, Oct 13, 2020 at 09:01:49PM +0100, Al Viro wrote: > On Tue, Oct 13, 2020 at 08:36:43PM +0100, Matthew Wilcox wrote: > > > static inline void copy_to_highpage(struct page *to, void *vfrom, unsigned int size) > > { > > char *vto = kmap_atomic(to); > > > > memcpy(vto, vfrom, size); > > kunmap_atomic(vto); > > } > > > > in linux/highmem.h ? > > You mean, like > static void memcpy_from_page(char *to, struct page *page, size_t offset, size_t len) > { > char *from = kmap_atomic(page); > memcpy(to, from + offset, len); > kunmap_atomic(from); > } > > static void memcpy_to_page(struct page *page, size_t offset, const char *from, size_t len) > { > char *to = kmap_atomic(page); > memcpy(to + offset, from, len); > kunmap_atomic(to); > } > > static void memzero_page(struct page *page, size_t offset, size_t len) > { > char *addr = kmap_atomic(page); > memset(addr + offset, 0, len); > kunmap_atomic(addr); > } > > in lib/iov_iter.c? FWIW, I don't like that "highpage" in the name and > highmem.h as location - these make perfect sense regardless of highmem; > they are normal memory operations with page + offset used instead of > a pointer... I was thinking along those lines as well especially because of the direction this patch set takes kmap(). Thanks for pointing these out to me. How about I lift them to a common header? But if not highmem.h where? Ira
Powered by blists - more mailing lists