linux-ext4 - Re: [RFC PATCH] ext4: use the normal helper to get the actual inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201014154858.GC18373@mit.edu>
Date:   Wed, 14 Oct 2020 11:48:58 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Lukas Czerner <lczerner@...hat.com>
Cc:     xiakaixu1987@...il.com, linux-ext4@...r.kernel.org,
        adilger.kernel@...ger.ca, Kaixu Xia <kaixuxia@...cent.com>
Subject: Re: [RFC PATCH] ext4: use the normal helper to get the actual inode

On Mon, Oct 12, 2020 at 11:33:04AM +0200, Lukas Czerner wrote:
> On Sat, Oct 10, 2020 at 04:10:16PM +0800, xiakaixu1987@...il.com wrote:
> > From: Kaixu Xia <kaixuxia@...cent.com>
> > 
> > Here we use the READ_ONCE to fix race conditions in ->d_compare() and
> > ->d_hash() when they are called in RCU-walk mode, seems we can use
> > the normal helper d_inode_rcu() to get the actual inode.
> 
> Looks good to me.
> Thanks!
> 
> Reviewed-by: Lukas Czerner <lczerner@...hat.com>

Thanks, applied.

				- Ted