linux-ext4 - Re: [PATCH] mke2fs.8: Improve valid block size documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Oct 2020 18:56:13 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     Jan Kara <jack@...e.cz>
Cc:     Ted Tso <tytso@....edu>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] mke2fs.8: Improve valid block size documentation

On Oct 13, 2020, at 7:38 AM, Jan Kara <jack@...e.cz> wrote:
> 
> Explain which valid block sizes mke2fs supports in more detail.
> 
> Signed-off-by: Jan Kara <jack@...e.cz>

Should this mention that the default block size is 4096 bytes for most
filesystems?

It might mention e.g. ppc64 or aarch64 can use 64KB page size, but this
is definitely an improvement already.

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> misc/mke2fs.8.in | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/misc/mke2fs.8.in b/misc/mke2fs.8.in
> index e6bfc6d6fd2d..0814d216f3a4 100644
> --- a/misc/mke2fs.8.in
> +++ b/misc/mke2fs.8.in
> @@ -207,10 +207,11 @@ manual page for more details.
> .SH OPTIONS
> .TP
> .BI \-b " block-size"
> -Specify the size of blocks in bytes.  Valid block-size values are 1024,
> -2048 and 4096 bytes per block.  If omitted,
> -block-size is heuristically determined by the filesystem size and
> -the expected usage of the filesystem (see the
> +Specify the size of blocks in bytes.  Valid block-size values are powers of two
> +from 1024 up to 65536 (however note that the kernel is able to mount only
> +filesystems with block-size smaller or equal to the system page size - 4k on
> +x86 systems). If omitted, block-size is heuristically determined by the
> +filesystem size and the expected usage of the filesystem (see the
> .B \-T
> option).  If
> .I block-size
> --
> 2.16.4
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)