linux-ext4 - Re: [PATCH v6] jbd2: avoid transaction reuse after reformatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201015144958.GC181507@mit.edu>
Date:   Thu, 15 Oct 2020 10:49:58 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     linux-ext4@...r.kernel.org,
        Fengnan Chang <changfengnan@...vision.com>, adilger@...ger.ca,
        changfengnan <fengnanchang@...mail.com>
Subject: Re: [PATCH v6] jbd2: avoid transaction reuse after reformatting

On Mon, Oct 12, 2020 at 06:49:00PM +0200, Jan Kara wrote:
> From: changfengnan <fengnanchang@...mail.com>
> 
> When ext4 is formatted with lazy_journal_init=1 and transactions from
> the previous filesystem are still on disk, it is possible that they are
> considered during a recovery after a crash. Because the checksum seed
> has changed, the CRC check will fail, and the journal recovery fails
> with checksum error although the journal is otherwise perfectly valid.
> Fix the problem by checking commit block time stamps to determine
> whether the data in the journal block is just stale or whether it is
> indeed corrupt.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Reviewed-by: Andreas Dilger <adilger@...ger.ca>
> Signed-off-by: Fengnan Chang <changfengnan@...vision.com>
> Signed-off-by: Jan Kara <jack@...e.cz>

Thanks, applied.

					- Ted