linux-ext4 - Re: [PATCH v2 2/2] ext4: print quota journalling mode on (re-)mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 18 Oct 2020 11:22:44 +0800
From:   kernel test robot <lkp@...el.com>
To:     Roman Anufriev <dotdot@...dex-team.ru>, linux-ext4@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, tytso@....edu, jack@...e.cz,
        dmtrmonakhov@...dex-team.ru, dotdot@...dex-team.ru
Subject: Re: [PATCH v2 2/2] ext4: print quota journalling mode on (re-)mount

Hi Roman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on ext4/dev]
[also build test ERROR on v5.9 next-20201016]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Roman-Anufriev/ext4-add-helpers-for-checking-whether-quota-can-be-enabled-is-journalled/20201018-100410
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
config: i386-randconfig-m021-20201018 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/9ee2e9dad32135b665f733b714c75ff22731bbcd
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Roman-Anufriev/ext4-add-helpers-for-checking-whether-quota-can-be-enabled-is-journalled/20201018-100410
        git checkout 9ee2e9dad32135b665f733b714c75ff22731bbcd
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   fs/ext4/super.c: In function 'ext4_quota_mode':
>> fs/ext4/super.c:3999:19: error: expected ';' before '}' token
    3999 |  return "disabled"
         |                   ^
         |                   ;
    4000 | #endif
    4001 | }
         | ~                  
   fs/ext4/super.c: In function 'ext4_remount':
   fs/ext4/super.c:5738:6: warning: variable 'enable_quota' set but not used [-Wunused-but-set-variable]
    5738 |  int enable_quota = 0;
         |      ^~~~~~~~~~~~

vim +3999 fs/ext4/super.c

  3987	
  3988	static const char *ext4_quota_mode(struct super_block *sb)
  3989	{
  3990	#ifdef CONFIG_QUOTA
  3991		if (!ext4_quota_capable(sb))
  3992			return "none";
  3993	
  3994		if (ext4_is_quota_journalled(sb))
  3995			return "journalled";
  3996		else
  3997			return "writeback";
  3998	#else
> 3999		return "disabled"
  4000	#endif
  4001	}
  4002	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (29784 bytes)