lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Oct 2020 05:29:49 +0800 From: David Gow <davidgow@...gle.com> To: Brendan Higgins <brendanhiggins@...gle.com> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>, "Theodore Ts'o" <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>, Shuah Khan <skhan@...uxfoundation.org>, Iurii Zaikin <yzaikin@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Matthieu Baerts <matthieu.baerts@...sares.net>, linux-ext4@...r.kernel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it On Thu, Oct 22, 2020 at 5:15 AM Brendan Higgins <brendanhiggins@...gle.com> wrote: > > On Tue, Oct 20, 2020 at 12:37 AM Geert Uytterhoeven > <geert@...ux-m68k.org> wrote: > > > > EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the > > user may not want to enable. Fix this by making the test depend on > > EXT4_FS instead. > > > > Fixes: 1cbeab1b242d16fd ("ext4: add kunit test for decoding extended timestamps") > > Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org> > > If I remember correctly, having EXT4_KUNIT_TESTS select EXT4_FS was > something that Ted specifically requested, but I don't have any strong > feelings on it either way. For what it's worth, the upcoming FAT filesystem tests[1] are also select-ing FAT_FS at the moment, so if this changes here, I'll likely update it there as well. -- David [1]: https://lore.kernel.org/linux-kselftest/20201021061713.1545931-1-davidgow@google.com/T/#u
Powered by blists - more mailing lists