linux-ext4 - Re: [PATCH v2 1/2] ext4: add helpers for checking whether quota can be enabled/is journalled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.OSX.2.23.453.2010220629560.1375@dotdot-osx>
Date:   Thu, 22 Oct 2020 06:33:53 +0300 (MSK)
From:   Roman Anufriev <dotdot@...dex-team.ru>
To:     Jan Kara <jack@...e.cz>
cc:     linux-ext4@...r.kernel.org, tytso@....edu,
        dmtrmonakhov@...dex-team.ru
Subject: Re: [PATCH v2 1/2] ext4: add helpers for checking whether quota can
 be enabled/is journalled

On Mon, 19 Oct 2020, Jan Kara wrote:

> On Mon 19-10-20 11:37:06, Jan Kara wrote:
>> On Sun 18-10-20 05:02:26, Roman Anufriev wrote:
>>> Right now, there are several places, where we check whether fs is
>>> capable of enabling quota or if quota is journalled with quite long
>>> and non-self-descriptive condition statements.
>>>
>>> This patch wraps these statements into helpers for better readability
>>> and easier usage.
>>>
>>> Signed-off-by: Roman Anufriev <dotdot@...dex-team.ru>
>>
>> Looks good to me. You can add:
>>
>> Reviewe-by: Jan Kara <jack@...e.cz>
>
> Now I've realized that if we run in nojournal mode, quota won't be
> journalled in any case. Probably not a configuration you run in but still
> we should get that right.

I forgot about this case. Fixed in v4:
https://lore.kernel.org/linux-ext4/1603336860-16153-1-git-send-email-dotdot@yandex-team.ru/

 								Roman