lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Oct 2020 16:38:16 +0000 From: Tianxianting <tian.xianting@....com> To: Jan Kara <jack@...e.cz>, "tytso@....edu" <tytso@....edu>, "adilger.kernel@...ger.ca" <adilger.kernel@...ger.ca> CC: "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH] ext4: remove the null check of bio_vec page Thanks Jan Can be the patch applied? -----Original Message----- From: Jan Kara [mailto:jack@...e.cz] Sent: Wednesday, October 21, 2020 6:25 PM To: tianxianting (RD) <tian.xianting@....com> Cc: tytso@....edu; adilger.kernel@...ger.ca; jack@...e.cz; linux-ext4@...r.kernel.org; linux-kernel@...r.kernel.org Subject: Re: [PATCH] ext4: remove the null check of bio_vec page On Tue 20-10-20 16:22:01, Xianting Tian wrote: > bv_page can't be NULL in a valid bio_vec, so we can remove the NULL > check, as we did in other places when calling > bio_for_each_segment_all() to go through all bio_vec of a bio. > > Signed-off-by: Xianting Tian <tian.xianting@....com> Thanks for the patch. It looks good to me. You can add: Reviewed-by: Jan Kara <jack@...e.cz> Honza > --- > fs/ext4/page-io.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c index > defd2e10d..cb135a944 100644 > --- a/fs/ext4/page-io.c > +++ b/fs/ext4/page-io.c > @@ -111,9 +111,6 @@ static void ext4_finish_bio(struct bio *bio) > unsigned under_io = 0; > unsigned long flags; > > - if (!page) > - continue; > - > if (fscrypt_is_bounce_page(page)) { > bounce_page = page; > page = fscrypt_pagecache_page(bounce_page); > -- > 2.17.1 > -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists