linux-ext4 - Re: [PATCH] ext4: do not use extent after put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Oct 2020 00:14:51 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     yangerkun <yangerkun@...wei.com>
Cc:     jack@...e.com, adilger@...ger.ca, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: do not use extent after put_bh

On Wed, Oct 28, 2020 at 01:56:17PM +0800, yangerkun wrote:
> ext4_ext_search_right will read more extent block and call put_bh after
> we get the information we need. However ret_ex will break this and may
> cause use-after-free once pagecache has been freed. Fix it by dup the
> extent we need.
> 
> Signed-off-by: yangerkun <yangerkun@...wei.com>

Good catch!

Thanks, applied.

					- Ted