linux-ext4 - Re: [PATCH] ext4: unlock xattr_sem properly in ext4_inline_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201107032930.GB2499342@mit.edu>
Date:   Fri, 6 Nov 2020 22:29:30 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     Joseph Qi <joseph.qi@...ux.alibaba.com>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>,
        Jan Kara <jack@...e.cz>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Tao Ma <boyu.mt@...bao.com>
Subject: Re: [PATCH] ext4: unlock xattr_sem properly in
 ext4_inline_data_truncate()

On Mon, Nov 02, 2020 at 08:15:36PM -0700, Andreas Dilger wrote:
> On Nov 2, 2020, at 7:29 PM, Joseph Qi <joseph.qi@...ux.alibaba.com> wrote:
> > 
> > It takes xattr_sem to check inline data again but without unlock it
> > in case not have. So unlock it before return.
> > 
> > Fixes: aef1c8513c1f ("ext4: let ext4_truncate handle inline data correctly")
> > Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> > Cc: Tao Ma <boyu.mt@...bao.com>
> > Signed-off-by: Joseph Qi <joseph.qi@...ux.alibaba.com>
> 
> Reviewed-by: Andreas Dilger <adilger@...ger.ca>

Thanks, applied.

					- Ted