linux-ext4 - Re: [PATCH 1/2] ext4: fix sparse warnings in fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 7 Nov 2020 16:11:37 -0800
From:   harshad shirwadkar <harshadshirwadkar@...il.com>
To:     "Theodore Ts'o" <tytso@....edu>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>,
        Harshad Shirwadkar <harshads@...gle.com>
Subject: Re: [PATCH 1/2] ext4: fix sparse warnings in fast_commit code

Thanks for the change, it looks good to me.

- Harshad

On Fri, Nov 6, 2020 at 9:14 PM Theodore Ts'o <tytso@....edu> wrote:
>
> Add missing __acquire() and __releases() annotations, and make
> fc_ineligible_reasons[] static, as it is not used outside of
> fs/ext4/fast_commit.c.
>
> Signed-off-by: Theodore Ts'o <tytso@....edu>
> ---
>  fs/ext4/fast_commit.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
> index 5cd6630ab1b9..f2033e13a273 100644
> --- a/fs/ext4/fast_commit.c
> +++ b/fs/ext4/fast_commit.c
> @@ -156,6 +156,7 @@ void ext4_fc_init_inode(struct inode *inode)
>
>  /* This function must be called with sbi->s_fc_lock held. */
>  static void ext4_fc_wait_committing_inode(struct inode *inode)
> +__releases(&EXT4_SB(inode->i_sb)->s_fc_lock)
>  {
>         wait_queue_head_t *wq;
>         struct ext4_inode_info *ei = EXT4_I(inode);
> @@ -911,6 +912,8 @@ static int ext4_fc_wait_inode_data_all(journal_t *journal)
>
>  /* Commit all the directory entry updates */
>  static int ext4_fc_commit_dentry_updates(journal_t *journal, u32 *crc)
> +__acquires(&sbi->s_fc_lock)
> +__releases(&sbi->s_fc_lock)
>  {
>         struct super_block *sb = (struct super_block *)(journal->j_private);
>         struct ext4_sb_info *sbi = EXT4_SB(sb);
> @@ -2106,7 +2109,7 @@ void ext4_fc_init(struct super_block *sb, journal_t *journal)
>         journal->j_fc_cleanup_callback = ext4_fc_cleanup;
>  }
>
> -const char *fc_ineligible_reasons[] = {
> +static const char *fc_ineligible_reasons[] = {
>         "Extended attributes changed",
>         "Cross rename",
>         "Journal flag changed",
> --
> 2.28.0
>