lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 18 Nov 2020 11:05:54 -0800
From:   Eric Biggers <>
To:     Daniel Rosenberg <>
Cc:     "Theodore Y . Ts'o" <>,
        Jaegeuk Kim <>,
        Andreas Dilger <>,
        Chao Yu <>,
        Alexander Viro <>,
        Richard Weinberger <>,,,,,,,
        Gabriel Krisman Bertazi <>,
Subject: Re: [PATCH v3 3/3] f2fs: Handle casefolding with Encryption

On Wed, Nov 18, 2020 at 06:42:45AM +0000, Daniel Rosenberg wrote:
> Expand f2fs's casefolding support to include encrypted directories.  To
> index casefolded+encrypted directories, we use the SipHash of the
> casefolded name, keyed by a key derived from the directory's fscrypt
> master key.  This ensures that the dirhash doesn't leak information
> about the plaintext filenames.
> Encryption keys are unavailable during roll-forward recovery, so we
> can't compute the dirhash when recovering a new dentry in an encrypted +
> casefolded directory.  To avoid having to force a checkpoint when a new
> file is fsync'ed, store the dirhash on-disk appended to i_name.
> This patch incorporates work by Eric Biggers <>
> and Jaegeuk Kim <>.
> Co-developed-by: Eric Biggers <>
> Signed-off-by: Eric Biggers <>
> Signed-off-by: Daniel Rosenberg <>

Looks good.  If it's needed (some may claim it's not needed because I have a
Co-developed-by), you can add:

	Reviewed-by: Eric Biggers <>

- Eric

Powered by blists - more mailing lists