lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 23 Nov 2020 09:54:48 +1100 (AEDT)
From:   Finn Thain <>
To:     Miguel Ojeda <>
cc:     James Bottomley <>,
        Kees Cook <>,
        Jakub Kicinski <>,
        "Gustavo A. R. Silva" <>,
        linux-kernel <>,,,,,,,,,,,,,,,,,,,
        Linux ARM <>,,,,,,
        Linux Crypto Mailing List <>,,
        Ext4 Developers List <>,,,,,,,,,
        linux-input <>,,,
        Linux Media Mailing List <>,, Linux-MM <>,,,,,,,,,,,
        linux-wireless <>,
        Network Development <>,,,,,,,,,,,,,,,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <>,,,
        Nick Desaulniers <>,
        Nathan Chancellor <>,
        Miguel Ojeda <>, Joe Perches <>
Subject: Re: [PATCH 000/141] Fix fall-through warnings for Clang

On Sun, 22 Nov 2020, Miguel Ojeda wrote:

> It isn't that much effort, isn't it? Plus we need to take into account 
> the future mistakes that it might prevent, too.

We should also take into account optimisim about future improvements in 

> So even if there were zero problems found so far, it is still a positive 
> change.

It is if you want to spin it that way.

> I would agree if these changes were high risk, though; but they are 
> almost trivial.

This is trivial:

 case 1:
+	fallthrough;
 case 2:

But what we inevitably get is changes like this:

 case 3:
+       break;
 case 4:

Why? Mainly to silence the compiler. Also because the patch author argued 
successfully that they had found a theoretical bug, often in mature code.

But is anyone keeping score of the regressions? If unreported bugs count, 
what about unreported regressions?

> Cheers,
> Miguel

Powered by blists - more mailing lists