linux-ext4 - Re: [RFC PATCH v3 50/61] e2fsck: move ext2fs_get_avg_group to rw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201124021244.GM132317@mit.edu>
Date:   Mon, 23 Nov 2020 21:12:44 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Saranya Muruganandam <saranyamohan@...gle.com>
Cc:     linux-ext4@...r.kernel.org, adilger.kernel@...ger.ca,
        Wang Shilong <wshilong@....com>,
        jenkins <devops@...mcloud.com>, Maloo <maloo@...mcloud.com>,
        Andreas Dilger <adilger@...mcloud.com>
Subject: Re: [RFC PATCH v3 50/61] e2fsck: move ext2fs_get_avg_group to
 rw_bitmaps.c

On Wed, Nov 18, 2020 at 07:39:36AM -0800, Saranya Muruganandam wrote:
> From: Wang Shilong <wshilong@....com>
> 
> A bounch of ext2fs_get_avg_group() unused warning messages are
> annoying, move it to rw_bitmaps.c to make gcc happy.

This should be merged with the commit that initially defined
ext2fs_get_avg_group() in the first place.

More generally, *all* of the "fix *" commits should be merged with the
original commits.  This will make it **so** much easier to review the
commits.

							- Ted