linux-ext4 - Re: [PATCH v3 07/38] mount: attach mappings to mounts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Dec 2020 08:25:56 -0500
From:   Tycho Andersen <tycho@...ho.pizza>
To:     Christoph Hellwig <hch@....de>
Cc:     Christian Brauner <christian.brauner@...ntu.com>,
        Lennart Poettering <lennart@...ttering.net>,
        Mimi Zohar <zohar@...ux.ibm.com>,
        David Howells <dhowells@...hat.com>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        containers@...ts.linux-foundation.org,
        Paul Moore <paul@...l-moore.com>,
        Jonathan Corbet <corbet@....net>, smbarber@...omium.org,
        Christoph Hellwig <hch@...radead.org>,
        Alban Crequy <alban@...volk.io>, linux-ext4@...r.kernel.org,
        Mrunal Patel <mpatel@...hat.com>,
        Kees Cook <keescook@...omium.org>,
        Arnd Bergmann <arnd@...db.de>, selinux@...r.kernel.org,
        Josh Triplett <josh@...htriplett.org>,
        Seth Forshee <seth.forshee@...onical.com>,
        Aleksa Sarai <cyphar@...har.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Andy Lutomirski <luto@...nel.org>,
        OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
        Geoffrey Thomas <geofft@...reload.com>,
        James Bottomley <James.Bottomley@...senpartnership.com>,
        John Johansen <john.johansen@...onical.com>,
        Theodore Tso <tytso@....edu>,
        Dmitry Kasatkin <dmitry.kasatkin@...il.com>,
        Stephen Smalley <stephen.smalley.work@...il.com>,
        fstests@...r.kernel.org, linux-security-module@...r.kernel.org,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        linux-api@...r.kernel.org,
        Casey Schaufler <casey@...aufler-ca.com>,
        linux-fsdevel@...r.kernel.org, linux-integrity@...r.kernel.org,
        Todd Kjos <tkjos@...gle.com>
Subject: Re: [PATCH v3 07/38] mount: attach mappings to mounts

On Tue, Dec 01, 2020 at 11:50:25AM +0100, Christoph Hellwig wrote:
> The READ_ONCE still looks suspect as it generally needs to be paired
> with a WRITE_ONCE.  The rest looks sane to me.

Yeah, the comment from the other location is,

/* Pairs with smp_load_acquire() in mnt_user_ns(). */

So I think it's just a typo that needs to be fixed.

Tycho