lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 01 Dec 2020 17:18:44 +0000 From: David Howells <dhowells@...hat.com> To: Eric Sandeen <sandeen@...hat.com> Cc: dhowells@...hat.com, torvalds@...ux-foundation.org, Miklos Szeredi <mszeredi@...hat.com>, Ira Weiny <ira.weiny@...el.com>, linux-fsdevel@...r.kernel.org, linux-man@...r.kernel.org, linux-kernel@...r.kernel.org, xfs <linux-xfs@...r.kernel.org>, linux-ext4@...r.kernel.org, Xiaoli Feng <xifeng@...hat.com> Subject: Re: [PATCH 1/2] uapi: fix statx attribute value overlap for DAX & MOUNT_ROOT Eric Sandeen <sandeen@...hat.com> wrote: > STATX_ATTR_MOUNT_ROOT and STATX_ATTR_DAX got merged with the same value, > so one of them needs fixing. Move STATX_ATTR_DAX. > > While we're in here, clarify the value-matching scheme for some of the > attributes, and explain why the value for DAX does not match. > > Signed-off-by: Eric Sandeen <sandeen@...hat.com> You should probably have one or two Fixes: lines in it. It might be worth referencing both of the patches that added conflicting bits. Fixes: 80340fe3605c ("statx: add mount_root") Fixes: 712b2698e4c0 ("fs/stat: Define DAX statx attribute") It should probably have: Reported-by: David Howells <dhowells@...hat.com> also as you mentioned that in the cover. You can also add: Reviewed-by: David Howells <dhowells@...hat.com> David
Powered by blists - more mailing lists