linux-ext4 - RE: [PATCH] ext4: remove the null check of bio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1758a0c58d174070915534f538aaf52d@h3c.com>
Date:   Fri, 4 Dec 2020 01:27:13 +0000
From:   Tianxianting <tian.xianting@....com>
To:     "Theodore Y. Ts'o" <tytso@....edu>, Jan Kara <jack@...e.cz>
CC:     "adilger.kernel@...ger.ca" <adilger.kernel@...ger.ca>,
        "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ext4: remove the null check of bio_vec page

Thanks Ted :)

-----Original Message-----
From: Theodore Y. Ts'o [mailto:tytso@....edu] 
Sent: Thursday, December 03, 2020 10:11 PM
To: Jan Kara <jack@...e.cz>
Cc: tianxianting (RD) <tian.xianting@....com>; adilger.kernel@...ger.ca; linux-ext4@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: remove the null check of bio_vec page

On Wed, Oct 21, 2020 at 12:25:03PM +0200, Jan Kara wrote:
> On Tue 20-10-20 16:22:01, Xianting Tian wrote:
> > bv_page can't be NULL in a valid bio_vec, so we can remove the NULL 
> > check, as we did in other places when calling 
> > bio_for_each_segment_all() to go through all bio_vec of a bio.
> > 
> > Signed-off-by: Xianting Tian <tian.xianting@....com>
> 
> Thanks for the patch. It looks good to me. You can add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>

Applied, thanks.

					- Ted