lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 6 Dec 2020 17:44:14 +0000 From: Colin Watson <cjwatson@...ntu.com> To: "Theodore Y. Ts'o" <tytso@....edu> Cc: Paul Menzel <pmenzel@...gen.mpg.de>, Andreas Dilger <adilger.kernel@...ger.ca>, linux-ext4@...r.kernel.org, Dimitri John Ledkov <xnox@...ntu.com> Subject: Re: ext4: Funny characters appended to file names On Sun, Dec 06, 2020 at 05:37:46PM +0000, Colin Watson wrote: > I don't know why Dimitri chose to explicitly remove the new files first > rather than just renaming over the top and then removing any leftovers > at the end; that seems unnecessarily risky. Though this is code that's > apparently supposed to work on Windows as well, and the MoveFile > function that's used to implement grub_util_rename there requires the > destination file not to exist (sigh), so maybe it had something to do > with that. Incidentally, if this is actually the reason, then I think this would be a viable replacement: ret = !MoveFileEx (windows_from, windows_to, MOVEFILE_REPLACE_EXISTING); Not that I really speak the Windows API ... -- Colin Watson (he/him) [cjwatson@...ntu.com]
Powered by blists - more mailing lists