linux-ext4 - discard feature, mkfs.ext4 and mmc default fallback to normal erase op

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <97c4bb65c8a3e688b191d57e9f06aa5a@walle.cc>
Date:   Mon, 07 Dec 2020 16:10:27 +0100
From:   Michael Walle <michael@...le.cc>
To:     linux-ext4@...r.kernel.org, linux-mmc@...r.kernel.org,
        linux-block@...r.kernel.org
Subject: discard feature, mkfs.ext4 and mmc default fallback to normal erase
 op

Hi,

The problem I'm having is that I'm trying to install debian on
an embedded system onto an sdcard. During installation it will
format the target filesystem, but the "mkfs.ext4 -F /dev/mmcblk0p2"
takes ages.

What I've found out so far:
  - mkfs.ext4 tries to discard all blocks on the target device
  - with my target device being an sdcard it seems to fallback
    to normal erase [1], with erase_arg being set to what the card
    is capable of [2]

Now I'm trying to figure out if this behavior is intended. I guess
one can reduce it to "blkdiscard /dev/mmcblk0p2". Should this
actually fall back to normal erasing or should it return -EOPNOTSUPP?

-michael

[1] 
https://elixir.bootlin.com/linux/v5.9.12/source/drivers/mmc/core/block.c#L1063
[2] 
https://elixir.bootlin.com/linux/v5.9.12/source/drivers/mmc/core/mmc.c#L1751